Fix some types of arguments in ast module
#14247
Open
+12
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Hmm, this doesn't look right. Where in the docs does it indicate this? Are you maybe going by the grammar at the top of the docs, and missed the definitions of Looking at the nodes at runtime suggests that the current stubs are correct: >>> ast.parse("# type: ignore", type_comments=True).type_ignores
[<ast.TypeIgnore object at 0x7000551b31d0>]
>>> ast.parse("""
... try:
... pass
... except:
... pass
... """).body[0].handlers
[<ast.ExceptHandler object at 0x7000551c8990>] |
|
Diff from mypy_primer, showing the effect of this PR on open source code: mypy (https://github.com/python/mypy)
+ mypy/fastparse.py:888: error: "type_ignore" has no attribute "tag" [attr-defined]
+ mypy/fastparse.py:890: error: "type_ignore" has no attribute "lineno" [attr-defined]
+ mypy/fastparse.py:892: error: "type_ignore" has no attribute "lineno" [attr-defined]
+ mypy/fastparse.py:1378: error: "excepthandler" has no attribute "name" [attr-defined]
+ mypy/fastparse.py:1378: error: Argument 2 to "set_line" of "ASTConverter" has incompatible type "excepthandler"; expected "Union[expr, stmt, ExceptHandler]" [arg-type]
+ mypy/fastparse.py:1380: error: "excepthandler" has no attribute "type" [attr-defined]
+ mypy/fastparse.py:1381: error: "excepthandler" has no attribute "body" [attr-defined]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ast document states that
Try/TryStarhave an attribute of typeexcepthandler, notExceptHandler. AlsoModulehas of typetype_ignore, notTypeIgnore.