[stdlib] Mark constants as Final #14577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
it wouldn't necessarily be a bad thing for that error to be emitted on |
This reverts commit b924e03.
|
Diff from mypy_primer, showing the effect of this PR on open source code: spack (https://github.com/spack/spack)
+ lib/spack/spack/util/url.py:91: error: Cannot assign to final name "uses_netloc" [misc]
+ lib/spack/spack/util/url.py:92: error: Cannot assign to final name "uses_relative" [misc]
+ lib/spack/spack/util/url.py:95: error: Cannot assign to final name "uses_netloc" [misc]
+ lib/spack/spack/util/url.py:96: error: Cannot assign to final name "uses_relative" [misc]
|
srittau
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR doesn’t aim to be exhaustive; I intentionally kept the scope limited to avoid making it too large. I expect to follow up with another PR to mark the remaining constants as Final.
And I followed the strategy of adding values only for constants whose values are explicitly defined and not simply bindings from any C library.