Add datetime types to Cachetools' TTLCache and TLRUCache classes
#14585
+24
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #8459 |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
I think a better approach would be to make |
|
Hi @srittau ! Thank you for your review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the type hints for these classes only include
floattypes. However, if you look at the documentation for both TTLCache and TLRUCache, one can see that you can usedatetimeandtimedeltaas yourtimerandttlrespectively.Because of the lack of these types in the type annotations, tools like mypy fail when trying to use
datetimeandtimedelta, which prevents people from using this capability when enforcing type safety.This PR fixes this problem by overriding the relevant functions typing and supporting these classes.