Removed mandatory enforcement of a dataclass check #2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r set" for dataclass fields in the `dataclasses_inheritance` test. This error is now optional for type checkers. Also fixed the conformance summary for pyright in the `aliases_typealiastype` test, which was out of date and didn't reflect the fact that pyright now passes this test.
carljm
approved these changes
Jun 10, 2025
JelleZijlstra
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed mandatory enforcement of "default value type of list, dict, or set" for dataclass fields in the
dataclasses_inheritancetest. This error is now optional for type checkers.The typing spec doesn't mandate such a rule. This particular test in the conformance suite was based on a part of PEP 557 that was not officially incorporated into the typing spec, so it's questionable whether it belongs in the conformance suite in the first place. None of the major type checkers currently implement this check. I tried implementing it in pyright, and it creates a bunch of false positives for libraries like pydantic and attrs that use
dataclass_transformand don't have this same limitation. See this thread for more details.Also fixed the conformance summary for pyright in the
aliases_typealiastypetest, which was out of date and didn't reflect the fact that pyright now passes this test.