fix(client): resolve double /api/v4 segments in _build_url method #3247
+30
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix URL construction bug when paths start with /api/v4/ - Add test case to reproduce and verify the fix - Maintain backward compatibility with existing behavior - Resolves longstanding bug affecting all versions from 5.0.0+ Closes python-gitlab#3246
68e8b67 to
d158706
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3247 +/- ##
=======================================
Coverage 97.32% 97.32%
=======================================
Files 98 98
Lines 6062 6065 +3
=======================================
+ Hits 5900 5903 +3
Misses 162 162
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a longstanding bug in the
_build_urlmethod that causes double/api/v4segments in URLs when paths start with/api/v4/.Problem
When calling
_build_urlwith a path like/api/v4/projects/123/security_settings, the method returns:Instead of the expected:
Solution
The fix detects paths starting with
/api/v4/and removes the duplicate prefix before constructing the final URL.Testing
Impact
This bug has existed in all versions from 5.0.0 onwards and affects any code using paths starting with
/api/v4/. The fix resolves a real-world issue encountered when trying to enable GitLab secret detection features.Closes #3246