-
Notifications
You must be signed in to change notification settings - Fork 92
Support injecting annotated types with Inject[]
#279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
12ec067
to
6c90998
Compare
@sheinbergon, would you mind reviewing this (with #263 as context)? Have I missed anything else? |
Sure. Will do it later on today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going over the codebase, annotated type re-creation seems correct. I do wonder if we should really support nested type defs as part of the practical use.
IMO, It just doesn't feel like a proper use case (especialy given what what _inject_marker
and _noinject_marker
aim to solve). If it were up to me, I would favor a more hierarchical approach
Anyhow, If you consider this valid (or if the rest of the codebase already does so), please ignore this comment, and I'll aprove this PR.
We should re-activate coverage measurement (I can't do it as a mainatiner, I believe)
Random driveby comment: when I still worked on this library I actually planned to get rid of the This could simplify some parts of the implementation but also comes with some drawbacks. |
You're right. I just sent @davidparsson an invitation to the GH organization (not just this repository), Coveralls needs to be granted access to the organization and then I think the repository needs to be activated in the Coveralls settings. Let me know if more information is needed about any of this. |
b0e856d
to
0afe423
Compare
This was missing in #263.
To avoid the test from passing by just binding the origin type.
0afe423
to
88441e0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #279 +/- ##
==========================================
+ Coverage 95.23% 95.29% +0.05%
==========================================
Files 1 1
Lines 567 574 +7
Branches 96 98 +2
==========================================
+ Hits 540 547 +7
Misses 20 20
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
`__metadata__` is never empty.
There might very well be internal benefits with this, but it would be a painful migration in large projects. I'm using this in a codebase with 1500+ |
This was missing in #263.