Fix #460 Improve bump_prerelease to alway get a newer version #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tomschr would you like me to add commits per change, 1 commit for all changes, or to squash it all into the PR, so the entire PR is 1 commit? |
|
Thank you @Learloj for all your work! Much appreciated! ❤️ I would consider it as complete now. If you don't have anything else to add or change, I'd like to squash-merge it to master soon.
I haven't noticed that! You are doing great! 👍 Again, thanks! |
|
@tomschr my pleasure! I greatly appreciate your fast replies & feedback, and happy to help out on one of the projects we use :-) I have nothing to add, so feel free to merge. |
…a newer version, and raising an empty prerelease version has the option to raise the patch version as well
Co-authored-by: Tom Schraitle <tomschr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #460 and contains the following changes:
I ran the test suites successfully, except for 'checks', which also failed before I made any change. I ensured I did not introduce any new errors in this suite. I also added quite a bunch of tests to validate the new functionality, and adjusted a few that changed due to changing existing functionality.
Open to any suggestions for improvement, as my Python experience is a bit limited :-)