overlays: Fix sc16is752-spi1 emulation #6996
Merged
+40
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[1] Removed the sc16is752-spi1 overlay, replacing it with an entry in overlay_map.dts that invokes sc16is75x-spi with specific parameters. This does not work because it fails to configure the SPI1 interface. Most such overlays would require the respective SPI interface to have already been configured using one of the spi<n>-<m> overlays, but it is not possible to do that using overlay_map, and it is unreasonable to suddenly impose that requirement on users. Work around that specific problem by adding an extra parameter to sc16is75x to configure SPI1. It's not ideal, but better than a complete dedicated overlay. Link: raspberrypi#6962 Fixes: ce20a8f ("overlays: sc16is75x: Add generic SPI overlay") Signed-off-by: Phil Elwell <phil@raspberrypi.com> [1] commit ce20a8f ("overlays: sc16is75x: Add generic SPI overlay")
This was referenced Aug 12, 2025
|
A better approach, agreed. Only little nit: name the new arg something like spi1-1cs-compat to even more state that this is to deal with legacy stuff |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Aug 13, 2025
See: raspberrypi/linux#6974 kernel: pisp_be: Stride alignment See: raspberrypi/linux#6985 kernel: drm/panel: ilitek-ili9881c: Restore missing lanes configuration for nwe080 panel See: raspberrypi/linux#6987 kernel: drivers: media: pisp_be: Fix alignment for V4L2_PIX_FMT_SRGGB8 See: raspberrypi/linux#6988 kernel: overlays: Fix sc16is752-spi1 emulation See: raspberrypi/linux#6996 kernel: arm64/dma-mapping: Fix arch_sync_dma_for_device to respect dir parameter See: raspberrypi/linux#6995
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Aug 13, 2025
See: raspberrypi/linux#6974 kernel: pisp_be: Stride alignment See: raspberrypi/linux#6985 kernel: drm/panel: ilitek-ili9881c: Restore missing lanes configuration for nwe080 panel See: raspberrypi/linux#6987 kernel: drivers: media: pisp_be: Fix alignment for V4L2_PIX_FMT_SRGGB8 See: raspberrypi/linux#6988 kernel: overlays: Fix sc16is752-spi1 emulation See: raspberrypi/linux#6996 kernel: arm64/dma-mapping: Fix arch_sync_dma_for_device to respect dir parameter See: raspberrypi/linux#6995
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[1] Removed the sc16is752-spi1 overlay, replacing it with an entry in overlay_map.dts that invokes sc16is75x-spi with specific parameters. This does not work because it fails to configure the SPI1 interface. Most such overlays would require the respective SPI interface to have already been configured using one of the spi- overlays, but it is not possible to do that using overlay_map, and it is unreasonable to suddenly impose that requirement on users.
Work around that specific problem by adding an extra parameter to sc16is75x to configure SPI1. It's not ideal, but better than a complete dedicated overlay.
Link: #6962
Fixes: ce20a8f ("overlays: sc16is75x: Add generic SPI overlay")
Signed-off-by: Phil Elwell phil@raspberrypi.com
[1] commit ce20a8f ("overlays: sc16is75x: Add generic SPI overlay")