Added device tree overlays for the rpi-power HAT. #7036
Conversation
| target-path = "/"; | ||
| __overlay__ { | ||
| rpi_power_hat_b: rpi-power-hat-b { | ||
| compatible = "Raspberry Pi,rpi-power-hat-b"; |
There was a problem hiding this comment.
The correct prefix for Raspberry Pi Ltd. is "raspberrypi".
| }; | ||
| }; | ||
| }; | ||
| }; |
There was a problem hiding this comment.
Git prefers all files to end with a newline.
| power2-monitor = <&pwr2_monitor>; | ||
|
|
||
| // HAT metadata | ||
| hat-name = "rpi-power-hat Bottom"; |
There was a problem hiding this comment.
I'm not sure what this is meant to do. If it's for human readability, the compatible string should be enough.
arch/arm/boot/dts/overlays/Makefile
Outdated
| @@ -247,6 +247,8 @@ dtbo-$(CONFIG_ARCH_BCM2835) += \ | |||
| rpi-fw-uart.dtbo \ | |||
| rpi-poe.dtbo \ | |||
| rpi-poe-plus.dtbo \ | |||
| rpi-power-hat-b-overlay.dtbo \ | |||
There was a problem hiding this comment.
The make rules transform *-overlay.dts into *.dtbo, so drop the -overlays here.
492b567 to
d2f1b8f
Compare
|
If you run |
|
And the overlay entries in README and Makefile must be in alphabetical order. |
d2f1b8f to
9d045b3
Compare
|
Checkpatch is complaining about undocumented DT compatible strings and MAINTAINERS needing updating - is it okay to ignore these warnings? |
|
Yes, I'll waive those. |
Added 2 overlays for the rpi-power HAT to operate in either TOP or BOTTOM mode. Modified makefile and readme accordingly Signed-off-by: Lucas Hoffmann <lucas.hoffmann@raspberrypi.com>
9d045b3 to
845f06f
Compare
Added 2 device tree overlays for the rpi-control-hat. One for 'bottom' mode and one for 'top' mode.