Fix authentication error when using --baseurl #8774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncw
requested changes
Aug 26, 2025
| @@ -79,6 +79,7 @@ func newServer(ctx context.Context, f fs.Fs, opt *Options, vfsOpt *vfscommon.Opt | |||
| gofakes3.WithoutVersioning(), | |||
| gofakes3.WithV4Auth(authlistResolver(opt.AuthKey)), | |||
| gofakes3.WithIntegrityCheck(true), // Check Content-MD5 if supplied | |||
| gofakes3.WithBaseURL(opt.HTTP.BaseURL), | |||
There was a problem hiding this comment.
This options doesn't exist! Was it hallucinated by your favorite LLM? Or are you planning to add it to our fork of gofakes3?
There was a problem hiding this comment.
Sorry I didn't get a notification for that. I'll take a look now - thanks :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
Fix the authentication error that happens when you use the --baseurl flag (with rclone serve s3)
Was the change discussed in an issue or in the forum before?
https://forum.rclone.org/t/serve-s3-signaturedoesnotmatch-error-when-using-baseurl/52325
Checklist