Skip to content

Conversation

n-studio
Copy link

@n-studio n-studio commented Jul 3, 2021

@benlangfeld
Copy link
Collaborator

benlangfeld commented Jul 5, 2021

Is there a way we can test this?

Please also include a changelog entry :)

@n-studio
Copy link
Author

n-studio commented Jul 6, 2021

Is there a way we can test this?

Please also include a changelog entry :)

I updated the changelog entry. I have no idea how to test it, but if you have an idea I can implement it.

@benlangfeld
Copy link
Collaborator

@aried3r How much do you care about test coverage for this, considering the difficulty in setting up multiple databases in CI?

@aried3r
Copy link
Member

aried3r commented Jul 9, 2021

I haven't yet needed to test multi-db Rails setups on CI myself, so I have to ask naively, shouldn't it be – at least for PostgreSQL – "just" another call do createdb?

I don't want to test Rails itself, but if there was even a single test that confirms that two DBs are being used, I'd appreciate it.

Could we also add a little bit of documentation to the README?

@nicdal
Copy link

nicdal commented Oct 19, 2023

Any plans to merge this to master?

@benlangfeld
Copy link
Collaborator

@n-studio Hey, sorry for the delay! Do you think you could:

  1. Add some docs in the readme.
  2. Setup a second database in CI and some example showing that multiple DBs are used.

Until those things are completed, I'm going to put this in draft state just to indicate that there's work to be done before a final review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple databases support
4 participants