Fix invalid retry-after header #737
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We’re seeing some invalid retry-after values, such as -1 or -2, for WebPush, which is causing the following error. Error type: ArgumentError Error message: not RFC 2616 compliant date: "-1" Where: <no information> Occurred at: Mar 21, 2025 04:26:42 UTC First seen at: Nov 12, 2024 21:51:53 UTC Occurrences: 170 (0 since last deploy on <no information>) Severity: error URL: <no information> File: /GEM_ROOT/gems/time-0.3.0/lib/time.rb Backtrace: /GEM_ROOT/gems/time-0.3.0/lib/time.rb:599:in httpdate /GEM_ROOT/bundler/gems/rpush-4ab018597541/lib/rpush/daemon/retry_header_parser.rb:18:in parse /GEM_ROOT/bundler/gems/rpush-4ab018597541/lib/rpush/daemon/retry_header_parser.rb:5:in parse /GEM_ROOT/bundler/gems/rpush-4ab018597541/lib/rpush/daemon/webpush/delivery.rb:94:in deliver_after_header /GEM_ROOT/bundler/gems/rpush-4ab018597541/lib/rpush/daemon/webpush/delivery.rb:78:in retry_delivery /GEM_ROOT/bundler/gems/rpush-4ab018597541/lib/rpush/daemon/webpush/delivery.rb:71:in process_response /GEM_ROOT/bundler/gems/rpush-4ab018597541/lib/rpush/daemon/webpush/delivery.rb:35:in perform /GEM_ROOT/bundler/gems/rpush-4ab018597541/lib/rpush/daemon/dispatcher/http.rb:12:in dispatch /GEM_ROOT/bundler/gems/rpush-4ab018597541/lib/rpush/daemon/dispatcher_loop.rb:66:in dispatch /GEM_ROOT/bundler/gems/rpush-4ab018597541/lib/rpush/daemon/dispatcher_loop.rb:35:in block (2 levels) in start /GEM_ROOT/bundler/gems/rpush-4ab018597541/lib/rpush/daemon/dispatcher_loop.rb:25:in loop /GEM_ROOT/bundler/gems/rpush-4ab018597541/lib/rpush/daemon/dispatcher_loop.rb:25:in block in start
|
Would you please write a changelog entry and a test for this? |
aaec917 to
9739e74
Compare
|
@benlangfeld I’ve added a test for this. Regarding the changelog, our version is a bit behind, so I can’t update |
You will need to merge the master branch into yours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We’re seeing some invalid retry-after values, such as
-1or-2, for WebPush, which is causing the following error.Error type: ArgumentError
Error message: not RFC 2616 compliant date: "-1"
Where:
Occurred at: Mar 21, 2025 04:26:42 UTC
First seen at: Nov 12, 2024 21:51:53 UTC
Occurrences: 170 (0 since last deploy on )
Severity: error
URL:
File: /GEM_ROOT/gems/time-0.3.0/lib/time.rb
Backtrace:
/GEM_ROOT/gems/time-0.3.0/lib/time.rb:599:in httpdate /GEM_ROOT/bundler/gems/rpush-4ab018597541/lib/rpush/daemon/retry_header_parser.rb:18:in parse /GEM_ROOT/bundler/gems/rpush-4ab018597541/lib/rpush/daemon/retry_header_parser.rb:5:in parse /GEM_ROOT/bundler/gems/rpush-4ab018597541/lib/rpush/daemon/webpush/delivery.rb:94:in deliver_after_header /GEM_ROOT/bundler/gems/rpush-4ab018597541/lib/rpush/daemon/webpush/delivery.rb:78:in retry_delivery /GEM_ROOT/bundler/gems/rpush-4ab018597541/lib/rpush/daemon/webpush/delivery.rb:71:in process_response /GEM_ROOT/bundler/gems/rpush-4ab018597541/lib/rpush/daemon/webpush/delivery.rb:35:in perform /GEM_ROOT/bundler/gems/rpush-4ab018597541/lib/rpush/daemon/dispatcher/http.rb:12:in dispatch /GEM_ROOT/bundler/gems/rpush-4ab018597541/lib/rpush/daemon/dispatcher_loop.rb:66:in dispatch /GEM_ROOT/bundler/gems/rpush-4ab018597541/lib/rpush/daemon/dispatcher_loop.rb:35:in block (2 levels) in start /GEM_ROOT/bundler/gems/rpush-4ab018597541/lib/rpush/daemon/dispatcher_loop.rb:25:in loop /GEM_ROOT/bundler/gems/rpush-4ab018597541/lib/rpush/daemon/dispatcher_loop.rb:25:in block in start