Get rid of SHAPE_T_OBJECT #13519
Closed
Get rid of SHAPE_T_OBJECT #13519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Tests Failed✖️no tests failed ✔️61823 tests passed(1 flake) |
76e9c04 to
8ca11b0
Compare
45c559c to
12d60fd
Compare
This was referenced Jun 6, 2025
12d60fd to
858d2df
Compare
This is preparation to getting rid of `T_OBJECT` transitions. By first only replicating the information it's easier to ensure consistency.
Now the `heap_index` is stored as flags inside `shape_id_t`. This saves having to rebuild the entire tree when moving from one slot size to the other.
b0048b5 to
1dda223
Compare
|
Merged most of this as #13556 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the
heap_indexis stored as flags insideshape_id_t.This saves having to rebuild the entire tree when moving from one slot size to the other.
It also potentially gives a cheap access to the slot size, whereas
rb_gc_obj_slot_sizeoften cause cache misses (but only for T_OBJECT right now. It could be valuable to have it for other types such as T_ARRAY, T_STRING as they often check the slot size).