Skip to content

ZJIT: Parse definedivar into HIR (+2 misc.) #13528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 6, 2025
Merged

ZJIT: Parse definedivar into HIR (+2 misc.) #13528

merged 4 commits into from
Jun 6, 2025

Conversation

XrXr
Copy link
Member

@XrXr XrXr commented Jun 5, 2025

  • ZJIT: Take a slice instead of Vec in test code
  • ZJIT: Parse definedivar into HIR
  • ZJIT: Fix insn arg index for defined, add tests

@XrXr
ZJIT: Take a slice instead of Vec in test code
26dfb8a 
Shorter code and more efficient.
@matzbot matzbot requested a review from a team June 5, 2025 15:51
tekknolagi
tekknolagi approved these changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@tekknolagi tekknolagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think over time we should rename these HIR instructions but since we're being consistent here, lgtm

@XrXr XrXr force-pushed the zjit-defined-ivar branch from 98a8ac1 to 06a67da Compare June 6, 2025 08:36
@XrXr XrXr enabled auto-merge (rebase) June 6, 2025 08:37
@XrXr XrXr merged commit 677c363 into ruby:master Jun 6, 2025
72 of 82 checks passed
@XrXr XrXr deleted the zjit-defined-ivar branch June 6, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tekknolagi tekknolagi tekknolagi approved these changes

@k0kubun k0kubun k0kubun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XrXr @tekknolagi @k0kubun