ZJIT: Parse a few more opt_*, CALL_SIMPLE_METHOD opcodes
#13549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
XrXr
commented
Jun 6, 2025
- ZJIT: Parse opt_empty_p into HIR
- ZJIT: Parse opt_succ into HIR
- ZJIT: Parse opt_and into HIR
- ZJIT: Parse opt_or into HIR
- ZJIT: Parse opt_not into HIR
- ZJIT: Parse opt_regexpmatch2 into HIR
tekknolagi
approved these changes
Jun 6, 2025
zjit/src/hir.rs
Outdated
| @@ -2325,6 +2325,9 @@ pub fn iseq_to_hir(iseq: *const rb_iseq_t) -> Result<Function, ParseError> { | |||
| break; // Don't enqueue the next block as a successor | |||
| } | |||
|
|
|||
| // These are opt_send_without_block and all the opt_* instructions | |||
| // specialized to a certain method that could also be serviced | |||
| // using the general send implementation. | |||
There was a problem hiding this comment.
Maybe say something also about how we optimize them later in the pipeline as part of the optimizer
|
Oh also please add some e2e/execution/Ruby-level tests |
d6a258a to
082d56d
Compare
k0kubun
approved these changes
Jun 6, 2025
db8a046 to
5439280
Compare
❌ Tests Failed✖️no tests failed ✔️61982 tests passed(2 flakes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.