Skip to content

Take file and line in GC VM locks #13550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025

Conversation

peterzhu2118
Copy link
Member

This commit adds file and line to GC VM locking functions for debugging purposes and adds upper case macros to pass FILE and LINE.

This commit adds file and line to GC VM locking functions for debugging
purposes and adds upper case macros to pass __FILE__ and __LINE__.
@ko1
Copy link
Contributor

ko1 commented Jun 7, 2025

Compare with this patch, I think using RB_VM_... api directly and introducing replacement for mod gc is smarter, but it's only my preference.

@peterzhu2118
Copy link
Member Author

I don't have a strong opinion, but my goal is to reduce the number of USE_MODULAR_GC /BUILDING_MODULAR_GC because it is divergent code path that need to be maintained separately.

@peterzhu2118 peterzhu2118 merged commit 837699e into ruby:master Jun 9, 2025
83 checks passed
@peterzhu2118 peterzhu2118 deleted the gc-vm-lock-file-line branch June 9, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants