Refactor the last references to rb_shape_t
#13586
Conversation
310b996 to
69f9ba0
Compare
❌ Tests Failed✖️1 test failed ✔️28791 tests passed(4 flakes) 22/137 test sessions failed❌ Test session #4472196 failed ❌ Test session #4472202 failed ❌ Test session #4472203 failed ❌ Test session #4472207 failed ❌ Test session #4472211 failed ❌ Test session #4472217 failed ❌ Test session #4472218 failed ❌ Test session #4472221 failed ❌ Test session #4472227 failed ❌ Test session #4472234 failed ❌ Test session #4472240 failed ❌ Test session #4472243 failed ❌ Test session #4472247 failed ❌ Test session #4472252 failed ❌ Test session #4472254 failed ❌ Test session #4472256 failed ❌ Test session #4472257 failed ❌ Test session #4472263 failed ❌ Test session #4472270 failed ❌ Test session #4472292 failed ❌ Test session #4472303 failed ❌ Test session #4472304 failed |
419c930 to
da0441f
Compare
The type isn't opaque because Ruby isn't often compiled with LTO, so for optimization purpose it's better to allow as much inlining as possible. However ideally only `shape.c` and `shape.h` should deal with the actual struct, and everything else should just deal with opaque `shape_id_t`.
da0441f to
85e6b6f
Compare
The type isn't opaque because Ruby isn't often compiled with LTO, so for optimization purpose it's better to allow as much inlining as possible.
However ideally only
shape.candshape.hshould deal with the actual struct, and everything else should just deal with opaqueshape_id_t.Also it probably be good to rename
rb_shape_tas it's no longer the actual shape, just part of it. Theshape_idnow actually contain important data too, not just a "pointer".