Skip to content

Add some missing write barriers on Time objects #13593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jhawthorn
Copy link
Member

This fixes three cases of missing write barriers as found by wbcheck (see #13213). They're likely all quite rare, but I think all real issues.

  • The timew was assigned to Time::tm without a write barrier. This is usually a FIXNUM, but can be rational or bignum for large dates.
  • zone was sometimes assigned without a write barrier
  • time_init_copy did not include write barriers. I would expect this to usually be run on a brand new object, but that isn't guaranteed

Copy link

launchable-app bot commented Jun 11, 2025

Tests Failed

✖️no tests failed ✔️61778 tests passed(45 flakes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant