CI: Surface Rust warnings on PRs that touch any Rust code #14173
+54
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabf5f8 to
68ba824
Compare
Since we're clean on warnings on |
st0012
approved these changes
Aug 11, 2025
k0kubun
reviewed
Aug 11, 2025
k0kubun
approved these changes
Aug 11, 2025
Rust PRs will have a failed CI step if they trigger any warnings. This helps us stay on top of warnings from new Rust releases and also ones we accidentally write. Fix a typo for demo, since this only runs when Rust files are changed.
68ba824 to
27df91c
Compare
❌ Tests Failed✖️no tests failed ✔️62276 tests passed(2 flakes) |
k0kubun
reviewed
Aug 15, 2025
| - name: Rust warnings | ||
| run: | | ||
| set -euo pipefail | ||
| cargo check --quiet --all-features --message-format=json \ |
There was a problem hiding this comment.
I wonder if there's a way to extract not only warnings but also errors with jq. It just silently fails right now.
https://github.com/ruby/ruby/actions/runs/16994039992/job/48180380659
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea is, if you create PRs touching Rust code often, you probably don't
mind being shown new warnings introduced in new Rust releases. They've
been trivial to fix and this will help us stay on top of them.
Closes Shopify#693