Skip to content

Make Enumerator::Chain and Enumerator::Product write-barrier protected #14182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2025
Merged

Make Enumerator::Chain and Enumerator::Product write-barrier protected #14182

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89f588d
Make Enumerator::Chain write-barrier protected
peterzhu2118 Aug 12, 2025
3a3df91
Make Enumerator::Product write-barrier protected
peterzhu2118 Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions enumerator.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3073,7 +3073,7 @@ static const rb_data_type_t enum_chain_data_type = {
enum_chain_memsize,
enum_chain_mark_and_move,
},
0, 0, RUBY_TYPED_FREE_IMMEDIATELY
0, 0, RUBY_TYPED_FREE_IMMEDIATELY | RUBY_TYPED_WB_PROTECTED
};

static struct enum_chain *
Expand Down Expand Up @@ -3123,7 +3123,7 @@ enum_chain_initialize(VALUE obj, VALUE enums)

if (!ptr) rb_raise(rb_eArgError, "unallocated chain");

ptr->enums = rb_ary_freeze(enums);
RB_OBJ_WRITE(obj, &ptr->enums, rb_ary_freeze(enums));
ptr->pos = -1;

return obj;
Expand Down Expand Up @@ -3157,7 +3157,7 @@ enum_chain_init_copy(VALUE obj, VALUE orig)

if (!ptr1) rb_raise(rb_eArgError, "unallocated chain");

ptr1->enums = ptr0->enums;
RB_OBJ_WRITE(obj, &ptr1->enums, ptr0->enums);
ptr1->pos = ptr0->pos;

return obj;
Expand Down Expand Up @@ -3388,7 +3388,7 @@ static const rb_data_type_t enum_product_data_type = {
enum_product_memsize,
enum_product_mark_and_move,
},
0, 0, RUBY_TYPED_FREE_IMMEDIATELY
0, 0, RUBY_TYPED_FREE_IMMEDIATELY | RUBY_TYPED_WB_PROTECTED
};

static struct enum_product *
Expand Down Expand Up @@ -3444,7 +3444,7 @@ enum_product_initialize(int argc, VALUE *argv, VALUE obj)

if (!ptr) rb_raise(rb_eArgError, "unallocated product");

ptr->enums = rb_ary_freeze(enums);
RB_OBJ_WRITE(obj, &ptr->enums, rb_ary_freeze(enums));

return obj;
}
Expand All @@ -3462,7 +3462,7 @@ enum_product_init_copy(VALUE obj, VALUE orig)

if (!ptr1) rb_raise(rb_eArgError, "unallocated product");

ptr1->enums = ptr0->enums;
RB_OBJ_WRITE(obj, &ptr1->enums, ptr0->enums);

return obj;
}
Expand Down
Loading