Implement gen_fields_tbl
cache
#14201
Merged
+44
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a high likelyhood that
rb_obj_fields
is called consecutively for the same object.If we keep a cache of the last IMEMO/fields we interacted with, we can save having to lookup the
gen_fields_tbl
, synchronize the VM lock, etc.On yjit-bench's, I instrumented the hit rate of this cache at:
shipit
: 38%, with 111k hits.lobsters
: 59%, with 367k hits.rubocop
: 100% with only 300 hits.I also ran a micro-benchmark which shows that ivar access is:
Single ractor:
Multi-ractor: