ZJIT: Remove a bunch of Option from codegen #14238
Merged
+177
−184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekknolagi
commented
Aug 15, 2025
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
b4bc4b6 to
dd8a496
Compare
|
Opening this up for review |
|
|
k0kubun
reviewed
Aug 15, 2025
cf3d97b to
65bf312
Compare
We have a verifier that runs in debug mode that should prevent this. Simplify a bunch of call sites.
They don't need it anymore; jit.get_opnd doesn't return Option anymore.
65bf312 to
a46575f
Compare
❌ Tests Failed✖️no tests failed ✔️62266 tests passed(1 flake) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to reduce the chance of accidentally having a not-implemented or
internal-compiler-error related side-exit after some code for an instruction
has already been emitted. So in this PR I make some of these ICEs cause a noisy
error and remove the spurious use of
Options.