Skip to content

ZJIT: 2 newrange fixes #14273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 19, 2025
Merged

ZJIT: 2 newrange fixes #14273

merged 2 commits into from
Aug 19, 2025
+46 −3

Conversation

XrXr
Copy link
Member

@XrXr XrXr commented Aug 19, 2025

  • ZJIT: Prepare for rb_range_new() calling <=>
  • ZJIT: Mark Insn::NewRange as having side effects

Fixes: Shopify#708

XrXr and others added 2 commits August 19, 2025 14:49
@XrXr @k0kubun @tekknolagi
ZJIT: Prepare for rb_range_new() calling <=>
a962b2a 
gen_prepare_call_with_gc() was not enough because of the rb_funcall()
usage in range_init().

Co-authored-by: Takashi Kokubun <takashikkbn@gmail.com>
Co-authored-by: Max Bernstein <rubybugs@bernsteinbear.com>
@XrXr
ZJIT: Mark Insn::NewRange as having side effects
b815305
@matzbot matzbot requested a review from a team August 19, 2025 19:15
tekknolagi
tekknolagi approved these changes Aug 19, 2025
View reviewed changes
Copy link
Contributor

@tekknolagi tekknolagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good -- we can rewrite to a hypothetical NewRangeFixnum in a pass later

@XrXr XrXr merged commit 6b197de into ruby:master Aug 19, 2025
87 checks passed
@XrXr XrXr deleted the zjit-newnrage-non-leaf branch August 19, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tekknolagi tekknolagi tekknolagi approved these changes

@k0kubun k0kubun k0kubun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ZJIT: gen_new_range should prepare for non-leaf
3 participants
@XrXr @tekknolagi @k0kubun