r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

The job tidy failed! Check out the build log: (web) (plain enhanced) (plain)

This has the same code as #144925 except with a few changes that break the build, and it has no attribute to that whatsoever. What was the idea behind this PR?

I wanted to introduce nothing new. It's just a pr with the suggested changes on #144925.

When you take code from somewhere else, you always need to indicate where you got it from and credit it appropriately, you can't just make it look like its your own. You didn't even include a note to the previous PR in the PR description, but ideally you would preserve the authorship of the commit itself so the original author shows up as the author of the commit.

I really didn't know about the credit part . In future I will make sure to give full credit. Thanks for educating about this part of open source .

👍 thanks. While it's of course important in open source, it really applies to anything, not just open source.