Skip to content

Rename append_row/column to push_row/column; add method push #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 1, 2021
Merged

Rename append_row/column to push_row/column; add method push #990

merged 3 commits into from
May 1, 2021

Conversation

bluss
Copy link
Member

@bluss bluss commented May 1, 2021 •
edited
Loading

Follow up to #932 by renaming append methods for consistency, as outlined in #932 (comment) :

// On 2-D arrays
fn push_row(&mut self, row: ArrayView<A, D::Smaller>) {}
fn push_column(&mut self, column: ArrayView<A, D::Smaller>) {}

// On n-D arrays
fn push(&mut self, axis: Axis, array: ArrayView<A, D::Smaller>) {}
fn append(&mut self, axis: Axis, array: ArrayView<A, D>) {}

This means we have two similar methods - push and append.

@bluss bluss changed the title Rename append_row/column to push_row/column Rename append_row/column to push_row/column; add method push May 1, 2021
bluss added 2 commits May 1, 2021 22:01
@bluss
append: Add method .push() for appending an array with a dimension less.
cae2544
@bluss
append: Avoid cloning dim values where possible
68c5be0 
While this has no effect for low-dimensionality arrays, for dyn dim it
can save some time.
@bluss bluss added this to the 0.15.2 milestone May 1, 2021
@bluss bluss merged commit 702de70 into master May 1, 2021
@bluss bluss deleted the push-append branch May 1, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.15.2
Development

Successfully merging this pull request may close these issues.
1 participant
@bluss