Feature up/ilm #470
Feature up/ilm #470
Conversation
…up/ilm # Conflicts: # crates/ecstore/src/client/api_get_object_acl.rs # crates/ecstore/src/client/api_get_object_attributes.rs # crates/ecstore/src/client/api_restore.rs # crates/ecstore/src/client/api_stat.rs # rustfs/src/storage/ecfs.rs
…up/ilm # Conflicts: # rustfs/src/admin/handlers/tier.rs
…up/ilm # Conflicts: # Cargo.lock # Cargo.toml
…up/ilm # Conflicts: # Cargo.lock
…up/ilm # Conflicts: # Cargo.lock
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the ILM (Information Lifecycle Management) feature to enhance object lifecycle management capabilities, particularly around version handling and transitioning objects between storage tiers.
- Added support for noncurrent version expiration limit handling with proper Arc pattern for the Lifecycle trait
- Implemented comprehensive integration tests for lifecycle expiry, delete markers, and transition scenarios
- Enhanced the scanner to properly handle version-aware lifecycle processing with file info validation
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/filemeta/src/filemeta.rs | Enhanced version management logic with update_version control flow and transition status handling |
| crates/ecstore/src/bucket/lifecycle/lifecycle.rs | Updated Lifecycle trait method signature and environment variable naming for ILM configuration |
| crates/ecstore/src/bucket/lifecycle/bucket_lifecycle_ops.rs | Updated environment variable names and added debug tracing capabilities |
| crates/ahm/tests/lifecycle_integration_test.rs | Added comprehensive integration tests for lifecycle operations including delete markers and transitions |
| crates/ahm/src/scanner/lifecycle.rs | Major refactoring to support version-aware lifecycle processing with proper object info handling |
| crates/ahm/src/scanner/data_scanner.rs | Enhanced data scanner to integrate with new lifecycle processing capabilities |
| crates/ahm/Cargo.toml | Added time dependency for temporal operations |
| .vscode/launch.json | Added debug configuration for lifecycle integration tests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| /*if fi.version_purge_status().is_empty() | ||
| { | ||
| update_version = fi.mark_deleted; | ||
| }*/ |
There was a problem hiding this comment.
The commented-out code should be removed rather than left in place. If this logic might be needed in the future, consider documenting the reasoning in a separate comment.
| /*if fi.version_purge_status().is_empty() | |
| { | |
| update_version = fi.mark_deleted; | |
| }*/ |
Copilot uses AI. Check for mistakes.
| if let Some(days) = expiration.days { | ||
| let expected_expiry = expected_expiry_time(obj.mod_time.expect("err!"), days /*, date*/); |
There was a problem hiding this comment.
The commented-out parameter , date in the function call should be removed for cleaner code.
| if let Some(days) = expiration.days { | |
| let expected_expiry = expected_expiry_time(obj.mod_time.expect("err!"), days /*, date*/); | |
| let expected_expiry = expected_expiry_time(obj.mod_time.expect("err!"), days); |
Copilot uses AI. Check for mistakes.
| </Rule> | ||
| <Rule> | ||
| <ID>test-rule2</ID> | ||
| <Status>Desabled</Status> |
There was a problem hiding this comment.
Typo in the XML status value. 'Desabled' should be 'Disabled'.
| <Status>Desabled</Status> | |
| <Status>Disabled</Status> |
Copilot uses AI. Check for mistakes.
| async fn test_lifecycle_transition_basic() { | ||
| let (_disk_paths, ecstore) = setup_test_env().await; | ||
|
|
||
| //create_test_tier().await; |
There was a problem hiding this comment.
Commented-out function call should be removed if not needed, or uncommented if it's required for the test.
| //create_test_tier().await; | |
Copilot uses AI. Check for mistakes.
# Conflicts: # Cargo.lock
…up/ilm # Conflicts: # Cargo.lock
…o feature-up/ilm # Conflicts: # Cargo.lock
upgrade ilm feature.
Type of Change