Skip to content

Conversation

wjhsf
Copy link
Contributor

@wjhsf wjhsf commented Aug 26, 2025

Details

  1. Sets type: module in the package.json and renames all .mjs to .js.
  2. The test and test-hydration directories were previously just symlinks to integration-karma. Now the files have been copied over, so that we can have divergent tests (i.e. migrate test/custom-elements-registry/index.spec.js) and eventually remove integration-karma entirely.

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.
  • 💔 Yes, it does introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.
  • 🔬 Yes, it does include an observable change.

GUS work item

wjhsf added 5 commits August 15, 2025 16:12
We can't mock individual methods of ESM modules in the browser,
so we use WTR's import map plugin to redirect all "lwc" imports to a mock file.
The mock file is mostly a re-export.
@wjhsf wjhsf requested a review from a team as a code owner August 26, 2025 17:48
Base automatically changed from wjh/wtr-again to master August 28, 2025 21:43
@wjhsf wjhsf enabled auto-merge (squash) September 2, 2025 18:56
@wjhsf
Copy link
Contributor Author

wjhsf commented Sep 2, 2025

/nucleus ignore --reason "Changes to internal test package shouldn't impact downstreams."

Copy link
Contributor

⚠ The test stage has a status of running, which cannot be ignored.

@wjhsf
Copy link
Contributor Author

wjhsf commented Sep 2, 2025

/nucleus ignore --reason "Changes to internal test package shouldn't impact downstreams."

Copy link
Contributor

⚠ The test stage has a status of cancelled, which cannot be ignored.

@wjhsf wjhsf merged commit 1596663 into master Sep 2, 2025
6 checks passed
@wjhsf wjhsf deleted the wjh/wtr-files branch September 2, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants