test(wtr): clean up hydration tests #5478
Open
+40
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of weird fake module
There's no setup/teardown needed, it's a single test, and WTR provides per-file encapsulation
working toward just importing and executing things, but not quite there yet
two env vars for the same goal is unnecessary
I think the last one was a concurrency related timeout, which was previously addressed.
wjhsf
commented
Sep 4, 2025
| config = config || {}; | ||
| ${moduleCode}; | ||
| moduleOutput = LWC.renderComponent( | ||
| `(() => { |
There was a problem hiding this comment.
The returned value when running a script is the result of the last statement of the script. Using an IIFE1 allows us to avoid mucking around with the context object.
1 Technically we can just do LWC.renderComponent() without wrapping it, but most people are probably unfamiliar with vm.Script. I think that using a more familiar pattern makes it more clear what's going on.
| }); | ||
| const { | ||
| default: { expectedSSRConsoleCalls, requiredFeatureFlags }, | ||
| } = await import(path.join(ROOT_DIR, filePath)); |
There was a problem hiding this comment.
We don't need all the extra bundling when import(configFile) works just fine.
rax-it
approved these changes
Sep 5, 2025
| @@ -100,7 +99,7 @@ function throwOnUnexpectedConsoleCalls(runnable, expectedConsoleCalls = {}) { | |||
| }; | |||
| } | |||
| try { | |||
| runnable(); | |||
| return runnable(); | |||
There was a problem hiding this comment.
🔔 TIL: even if we return in try catch, finally still gets executed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
ENABLE_SYNTHETIC_IN_HYDRATION_MODEdoes the same thing asDISABLE_SYNTHETIC, just reversed.serve-hydrationplugin a bit. The goal is to get everything as close to pure ESM as possible, rather than confusing layers of wrapping and bundling and indirection.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item