ValueError: filedescriptor out of range in select() #68136
Conversation
|
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey. There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
5ba7e58 to
3bf52b0
Compare
What does this PR do?
This PR replaces the use of
select.select()in therecv()method with the higher-level selectors API (selectors.DefaultSelector), eliminating the fixedFD_SETSIZElimit. Specifically, whentimeout == 0, it now:Registers the socket for read events on a
DefaultSelectorCalls
selector.select(timeout=0)instead ofselect.select([...], [], [], 0)Processes any ready file descriptors directly from the selector results
By using selectors, the code automatically leverages the best available backend (epoll, kqueue, poll, etc.) and lifts the file-descriptor range restriction, preventing the “filedescriptor out of range in select()” errors on systems with high FD numbers.
What issues does this PR fix or reference?
#65878
#63404
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No