Implement jl.Math.{multiplyFull, multiplyHigh, unsignedMultiplyHigh}. #5175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
87e5ed7 to
7569c24
Compare
gzm0
requested changes
May 21, 2025
| /* We fuzz-test by comparing to the "obvious" implementations based on | ||
| * BigIntegers. We use a SplittableRandom generator, because Random cannot | ||
| * generate all Long values. | ||
| */ |
There was a problem hiding this comment.
Doing this in runtime concerns me, because it relies on our own BigInteger implementation for correctness (in fact, nothing seems to prevent our BigInteger implementation to rely on the math implementation here that we are testing).
Do you think we could just expand some test cases out? (Given the complexity of the method under test, I think 50 or 100 cases like above should be way enough).
There was a problem hiding this comment.
Fair enough. I'll expand the test cases.
linker/shared/src/main/scala/org/scalajs/linker/frontend/optimizer/OptimizerCore.scala
Show resolved
Hide resolved
This way, we only have `require-jdk*` directories for JDK versions that we actually test in our CI. They also correspond to JDK LTS versions, so they are not arbitrary.
gzm0
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JavaDocs starting at https://docs.oracle.com/en/java/javase/24/docs/api/java.base/java/lang/Math.html#multiplyFull(int,int)
multiplyFullandmultiplyHighwere added in JDK 9.unsignedMultiplyHighwas added in JDK 18.