Introduce a Scala-agnostic API for Reflect. #5183
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new API is offered as part of the `javalibintf`. It only uses classes from the javalib, which makes it Scala-agnostic. The old binary API used by the codegen calls the new (public) API in javalibintf. We deprecate them, but keep them for backward binary compatibility. The public API of `scala.scalajs.reflect.Reflect` is left untouched, and is still the recommended way to access the public features from user-land Scala code. In this commit, we do not change the compiler yet, to test that the deprecated methods are correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new API is offered as part of the
javalibintf. It only uses classes from the javalib, which makes it Scala-agnostic.The old binary API used by the codegen calls the new (public) API in javalibintf. We deprecate them, but keep them for backward binary compatibility.
The public API of
scala.scalajs.reflect.Reflectis left untouched, and is still the recommended way to access the public features from user-land Scala code.In the first commit, we do not change the compiler yet, to test that the deprecated methods are correct.
In the second commit, we change the compiler to use the new APIs.
Alternative to #5161.