DOC Add link to spectral coclustering #31422
Conversation
There was a problem hiding this comment.
Hi @sidrtx,
thanks for your contribution to take up a stalled PR.
Differing from the previous review in #29606, I would not add this link to doc/modules/biclustering.rst, since it is already mentioned there (in li. 47 and 152) and we try to keep the docs rather clean. That was probably an oversight.
I would kindly ask you to remove this link again from doc/modules/biclustering.rst . Sorry about that.
Otherwise it looks fine.
sklearn/cluster/_bicluster.py
Outdated
| @@ -307,6 +307,9 @@ class SpectralCoclustering(BaseSpectral): | |||
| array([0, 0], dtype=int32) | |||
| >>> clustering | |||
| SpectralCoclustering(n_clusters=2, random_state=0) | |||
|
|
|||
| For a more detailed example, see the following: | |||
| :ref:`sphx_glr_auto_examples_bicluster_plot_spectral_coclustering.py` | |||
There was a problem hiding this comment.
| :ref:`sphx_glr_auto_examples_bicluster_plot_spectral_coclustering.py` | |
| :ref:`sphx_glr_auto_examples_bicluster_plot_spectral_coclustering.py`. |
Nit suggestion to add a dot.
|
Thank you for pointing out the references in lines 47 and 152—I must have missed those. I agree that removing them helps keep the documentation uncluttered. I’ve updated my PR accordingly. Thanks again for your attention to detail! |
There was a problem hiding this comment.
Thanks for your work and removing the other links, @sidrtx!
It looks fine to me now.
@adrinjalali or @betatim, do you want to have a look?
|
There were some CI workflows that needed approval to run, I gave that approval and enabled auto-merge. Thanks for helping make the examples more discoverable! |
Co-authored-by: Cloponaclock1 <ctramill2017@outlook.com>
Co-authored-by: Cloponaclock1 <ctramill2017@outlook.com>
Co-authored-by: Cloponaclock1 <ctramill2017@outlook.com>
Reference Issues/PRs
Towards #30621
Continues PR #29606
What does this implement/fix? Explain your changes.
Fixed the indentation that was requested and added link of spectral coclustering to
doc/modules/biclustering.rstAny other comments?
this continues the work from PR #29606