Skip to content

GOV more pragmatic decision making process for small PRs #31430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

GOV more pragmatic decision making process for small PRs #31430

wants to merge 1 commit into from

Conversation

lorentzenchr
Copy link
Member

Reference Issues/PRs

This was discussed during the monthly meeting 2025-03-31 https://github.com/scikit-learn/administrative/blob/master/monthly_meetings/2025-03-31.md.

What does this implement/fix? Explain your changes.

Make it easier for smaller PRs to be merged by only requiring 1 review.

Any other comments?

Changed "maintainer" by the newer term "core contributor".

@github-actions GitHub Actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: f40d134. Link to the linter CI: here

@lorentzenchr lorentzenchr changed the title GOV more pragmatic decision making process for small PRs. GOV more pragmatic decision making process for small PRs May 26, 2025
GaelVaroquaux
GaelVaroquaux approved these changes May 26, 2025
View reviewed changes
Copy link
Member

@GaelVaroquaux GaelVaroquaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!!

@lorentzenchr
Copy link
Member Author

@scikit-learn/core-devs @scikit-learn/communication-team @scikit-learn/contributor-experience-team @scikit-learn/documentation-team Open for voting.

PS: Hope I pinged correctly 😄

@reshamas
Copy link
Member

@thomasjpfan I thought we had moved away from the "core contributor" terminology. Otherwise it implies all other roles are "non-core".

@thomasjpfan
Copy link
Member

thomasjpfan commented May 28, 2025 •
edited
Loading

@reshamas With the current governance, all the named roles are considered "core". Specifically, the contributor experience, communication, documentation, and maintainer teams are all "core contributors".

Before this PR, only the maintainer team can approve PRs. With this PR, any of the other teams can approve PRs. Although, in practice, I think we normally considered the other approvals as valid.

@lorentzenchr
Copy link
Member Author

@reshamas Earlier it was „core developer“ or „core maintainer“. Because we have more roles than just devs or maintainers, we called the privileged group (voting right etc) „core contributor“.

@lorentzenchr
Copy link
Member Author

@reshamas So particular you have voting rights!

ArturoAmorQ
ArturoAmorQ approved these changes May 28, 2025
View reviewed changes
Copy link
Member

@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honest question, shall we modify the terminology across the documentation e.g. in about.rst? Such that it's clear who are those referred here.

In any case I'm giving my +1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@agramfort agramfort agramfort approved these changes

@GaelVaroquaux GaelVaroquaux GaelVaroquaux approved these changes

@betatim betatim betatim approved these changes

@adrinjalali adrinjalali adrinjalali approved these changes

@lesteve lesteve lesteve approved these changes

@reshamas reshamas reshamas approved these changes

@adam2392 adam2392 adam2392 approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@glemaitre glemaitre glemaitre approved these changes

@jjerphan jjerphan jjerphan approved these changes

@marenwestermann marenwestermann marenwestermann approved these changes

@OmarManzoor OmarManzoor OmarManzoor approved these changes

@lucyleeow lucyleeow lucyleeow approved these changes

@virchan virchan virchan approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

@ArturoAmorQ ArturoAmorQ ArturoAmorQ approved these changes

@StefanieSenger StefanieSenger StefanieSenger approved these changes

@francoisgoupil francoisgoupil francoisgoupil approved these changes

@Charlie-XIAO Charlie-XIAO Charlie-XIAO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.