TST Fix array API test_fill_or_add_to_diagonal
#31439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_fill_or_add_to_diagonaltest_fill_or_add_to_diagonal
ogrisel
reviewed
May 28, 2025
There was a problem hiding this comment.
I don't understand the purpose of the test anymore: the original numpy array is already an array of ones (it's allocated with zeros before calling numpy.fill_diagonal(array_np, val=1, wrap=wrap) on it. Then the xp array is created from the numpy array, so it's also an array of ones.
So calling _fill_or_add_to_diagonal with value=1, add_value=False is doing nothing.
The intent of the test feels muddled as a result.
I think we should initialize the xp array with zeros instead.
|
@ogrisel you're right. I fixed the order, because it would have been more difficult to specify dtype using |
ogrisel
approved these changes
May 28, 2025
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
May 30, 2025
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
elhambbi
pushed a commit
to elhambbi/scikit-learn
that referenced
this pull request
Jun 1, 2025
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
jeremiedbb
pushed a commit
that referenced
this pull request
Jun 5, 2025
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
dtype_namefrom parametrization intest_fill_or_add_to_diagonal.array_api_dispatchconfigWhat does this implement/fix? Explain your changes.
Any other comments?
@OmarManzoor I think this test should use the
dtype_nameparametrizations, and not just test int64?