FEA return final cross-validation score in SequentialFeatureSelector #31483
+70
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarManzoor
reviewed
Jun 10, 2025
doc/whats_new/upcoming_changes/sklearn.feature_selection/31483.feature.rst
Outdated
Show resolved
Hide resolved
OmarManzoor
approved these changes
Jun 11, 2025
adrinjalali
reviewed
Jun 12, 2025
|
See latest changes to address your comments |
adrinjalali
reviewed
Jun 12, 2025
Comment on lines
+364
to
+374
| cloned_estimator = clone(self.estimator) | ||
|
|
||
| return cross_val_score( | ||
| cloned_estimator, | ||
| X_new, | ||
| y, | ||
| cv=cv, | ||
| scoring=self.scoring, | ||
| n_jobs=self.n_jobs, | ||
| params=params if _routing_enabled() else None, | ||
| ).mean() |
There was a problem hiding this comment.
Suggested change
| cloned_estimator = clone(self.estimator) | |
| return cross_val_score( | |
| cloned_estimator, | |
| X_new, | |
| y, | |
| cv=cv, | |
| scoring=self.scoring, | |
| n_jobs=self.n_jobs, | |
| params=params if _routing_enabled() else None, | |
| ).mean() | |
| return cross_val_score( | |
| clone(self.estimator), | |
| X_new, | |
| y, | |
| cv=cv, | |
| scoring=self.scoring, | |
| n_jobs=self.n_jobs, | |
| params=params if _routing_enabled() else None, | |
| ) |
| cv=cv, | ||
| scoring=self.scoring, | ||
| n_jobs=self.n_jobs, | ||
| params=params if _routing_enabled() else None, |
There was a problem hiding this comment.
there should be a _raise_for_params for this.
| check_is_fitted(self) | ||
|
|
||
| X_new = X[:, self.support_] | ||
| cv = check_cv(self.cv, y, classifier=is_classifier(self.estimator)) |
There was a problem hiding this comment.
we could have a self._get_cv() to not repeat this line.
Comment on lines
+357
to
+358
| score : float | ||
| The mean cross-validation score of the selected feature set. |
There was a problem hiding this comment.
we might want to return raw values instead.
adrinjalali
reviewed
Jun 12, 2025
doc/whats_new/upcoming_changes/sklearn.feature_selection/31483.feature.rst
Outdated
Show resolved
Hide resolved
….feature.rst update based on PR suggestions Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.