-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
DOC: add link to the plot_mahalanobis_distances example #31485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
DOC: add link to the plot_mahalanobis_distances example #31485
Conversation
@StefanieSenger, I added link to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, @natmokval! I have a few comments.
For an example of using covariance estimation with Mahalanobis | ||
distances on Gaussian distributed data, refer to | ||
:ref:`sphx_glr_auto_examples_covariance_plot_mahalanobis_distances.py` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be better idea to place this inside the mahalanobis
method's docstring. Also,
"For a detailed example of how outlying data affects the Mahalanobis distance, see <example_link>."
The same applies to MinCovDet
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @virchan for reviewing my PR! I moved the link to the plot_mahalanobis_distances
example into the mahalanobis
method’s docstring, as you suggested. I don’t think a reference is needed in MinCovDet
anymore after that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating the PR, @natmokval! I have a few more comments.
|
||
Notes | ||
----- | ||
For a detailed example of how outlying data affects the Mahalanobis distance, | ||
see :ref:`sphx_glr_auto_examples_covariance_plot_mahalanobis_distances.py`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please place this before the "Parameters" section? Also, I think we don't need "Notes" here.
Towards #30621
This PR adds a reference to the
plot_mahalanobis_distances.py
.The
plot_mahalanobis_distances.py
example is already referenced in the User Guide. I added a link to make the example visible from the API documentation as well.