FIX _safe_indexing: improve error message for string indexing on axis=0 #31494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Linting issuesThis PR is introducing linting issues. Here's a summary of the issues. Note that you can avoid having linting issues by enabling You can see the details of the linting issues under the
|
adrinjalali
reviewed
Jun 12, 2025
adrinjalali
reviewed
Jun 12, 2025
Comment on lines
+293
to
+295
| raise ValueError( | ||
| f"String indexing (indices={indices}) is not supported with 'axis=0'. Did you mean to use axis=1 for column selection?" | ||
| ) |
There was a problem hiding this comment.
Suggested change
| raise ValueError( | |
| f"String indexing (indices={indices}) is not supported with 'axis=0'. Did you mean to use axis=1 for column selection?" | |
| ) | |
| raise ValueError( | |
| f"String indexing (indices={indices}) is not supported with 'axis=0'. " | |
| "Did you mean to use axis=1 for column selection?" | |
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the ValueError from sklearn.utils._indexing._safe_indexing more informative
when a string index is passed with axis=0. The new message shows the actual value of
indicesand suggests using axis=1 for column selection.ValueError(f"String indexing (indices={indices}) is not supported with 'axis=0'. "
"Did you mean to use axis=1 for column selection?")
(using a regex).
All existing indexing tests now pass. The only local test failure is test_openmp_parallelism_enabled,
which can be ignored on macOS; CI will run on Linux with OpenMP support.