Skip to content

FIX short deprecation cycle for private module #31500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

FIX short deprecation cycle for private module #31500

wants to merge 2 commits into from

Conversation

glemaitre
Copy link
Member

In #30763, we reorganize the module for the repr of estimator. The public functions associated with this module and that could be potentially used by developer of third-party libraries should not have subject to any breaking changes.

Right now, we are breaking the code of people if they were importing from the module. Let's be a bit more gentle and just warn for a cycle before to remove the module.

@glemaitre glemaitre added this to the 1.7.1 milestone Jun 6, 2025
@glemaitre
Copy link
Member Author

I added this PR to the 1.7.1 milestone.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 97f07a9. Link to the linter CI: here

thomasjpfan
thomasjpfan reviewed Jun 6, 2025
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think we normally had deprecation cycle for a private module. Was this private module use in a library you know about?

@glemaitre
Copy link
Member Author

It was skrub. One thing that we did in the past was to be a bit more gentled with the utils when we moved things around. Here, we did not yet decide what thing of the repr should be used by third-party libraries. I thought that we could be extra nice until we converged to something a bit more stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
module:utils No Changelog Needed
Projects
None yet
Milestone
1.7.1
Development

Successfully merging this pull request may close these issues.
2 participants
@glemaitre @thomasjpfan