Skip to content

DOC Update About Us page #31519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Conversation

reshamas
Copy link
Member

@reshamas reshamas commented Jun 10, 2025

Reference Issues/PRs

References #30826

What does this implement/fix? Explain your changes.

  • Emeritus contributors: make 3 columns to reduce whitespace
  • Change "Artwork" to "Branding & Logos"
    • add link to the branding guide
  • Funding
    • Donations in Kind: Infrastructure Support (this section seems like it would fit better under "Funding")
    • Donations in Kind: add in GitHub
    • put Coding sprints in the Funding section
  • Donating to the project
    • Add button for Benevity
    • Add info for Swag

Any other comments?

Copy link

github-actions bot commented Jun 10, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 2547228. Link to the linter CI: here

@reshamas reshamas changed the title [DRAFT - not ready for review] DOC Update Donations section DOC Update About Us page Jun 10, 2025
@reshamas reshamas requested a review from glemaitre June 10, 2025 22:39
@lucyleeow
Copy link
Member

I wonder if the CI failure is due to:

checking consistency... /home/circleci/project/doc/maintainers_emeritus.rst: WARNING: document isn't included in any toctree

(those image warnings are sure annoying to grep through, I am assuming it is because we don't run the examples so they are missing)

doc/about.rst Outdated
.. include:: maintainers_emeritus.rst
.. raw:: html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the error is coming from here, since the link to maintainers_emeritus.rst is being removed. I rather keep the link though, to have one place to keep that information. The same way for other sections like the communication team section.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to keep the file. The new proposed layout looks like this, and it save 28 lines of whitespace. So users can get to the important section faster, how to support scikit-learn.

Before

Screenshot 2025-06-12 at 6 53 17 AM

After

Screenshot 2025-06-12 at 6 52 40 AM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much nicer but it would be nice to have this list only in one place, so you don't have to update in 2 places when you want to change.

This may be too annoying to implement/maintain, but it may be possible to have the multi-column list and use include by having special CSS (that does the multi-column thing) and putting the include inside a container directive.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did try several ways and ran into some errors.

{csv-table} Emeritus Maintainers
:widths: 20, 20, 20

"Mathieu Blondel", "Joris Van den Bossche", "Matthieu Brucher"
"Lars Buitinck", "David Cournapeau", "Noel Dawe"
"Vincent Dubourg", "Edouard Duchesnay", "Alexander Fabisch"
"Virgile Fritsch", "Satrajit Ghosh", "Angel Soler Gollonet"
"Chris Gorgolewski", "Jaques Grobler", "Yaroslav Halchenko"
"Brian Holt", "Arnaud Joly", "Thouis (Ray) Jones"
"Kyle Kastner", "Manoj Kumar", "Robert Layton" 
"Wei Li", "Paolo Losi", "Gilles Louppe"
"Jan Hendrik Metzen", "Vincent Michel", "Jarrod Millman"
"Vlad Niculae", "Alexandre Passos", "Fabian Pedregosa"
"Peter Prettenhofer", "Hanmin Qin", "(Venkat) Raghav Rajagopalan"
"Jacob Schreiber", "杜世橋 Du Shiqiao", "Bertrand Thirion"
"Tom Dupré la Tour", "Jake Vanderplas", "Nelle Varoquaux"
"David Warde-Farley", "Ron Weiss", "Roman Yurchak"
==========================  ==========================  ==========================
Name                        Name                        Name
==========================  ==========================  ==========================
Mathieu Blondel             Joris Van den Bossche       Matthieu Brucher          
Lars Buitinck               David Cournapeau            Noel Dawe                 
Vincent Dubourg             Edouard Duchesnay           Alexander Fabisch         
Virgile Fritsch             Satrajit Ghosh              Angel Soler Gollonet      
Chris Gorgolewski           Jaques Grobler              Yaroslav Halchenko        
Brian Holt                  Arnaud Joly                 Thouis (Ray) Jones        
Kyle Kastner                Manoj Kumar                 Robert Layton             
Wei Li                      Paolo Losi                  Gilles Louppe             
Jan Hendrik Metzen          Vincent Michel              Jarrod Millman            
Vlad Niculae                Alexandre Passos            Fabian Pedregosa          
Peter Prettenhofer          Hanmin Qin                  (Venkat) Raghav, Rajagopalan
Jacob Schreiber             杜世橋 Du Shiqiao            Bertrand Thirion          
Tom Dupré la Tour           Jake Vanderplas             Nelle Varoquaux           
David Warde-Farley          Ron Weiss                   Roman Yurchak             
==========================  ==========================  ==========================

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another option is to remove the new HTML table for the emeritus contributors in this PR, and try it in a new PR, so it's not holding this up. I did make a lot of updates in various sections, so breaking up the PR is one way to move forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants