ENH/DOC clearer sample weight validation error msg #31873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
reviewed
Aug 4, 2025
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
adrinjalali
reviewed
Aug 4, 2025
|
I can't work out why one of the required test is failing, is there anything I can change to fix it? test name: |
adrinjalali
requested changes
Aug 4, 2025
|
Oops I've edited it now I thought the convention was to have issue number followed by bug/ enhancement etc .rst |
Amazing thank you for approving my PR. Is there anything else I need to do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #31712
What does this implement/fix? Explain your changes.
sklearn.utils._check_sample_weight used to raise
ValueError: Sample weights must be 1D array or scalar,
which was misleading (scalars are accepted) and gave no clue about the bad input.
This PR replaces that with a string
"Sample weights must be a scalar or a 1-D array-like of length n_samples. "
f"Got ndim={sample_weight.ndim} instead."
Any other comments?