DOC remove custom scorer from scratch from docs #31890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virchan
approved these changes
Aug 18, 2025
There was a problem hiding this comment.
LGTM! Thanks, @adrinjalali!
I also agree that a separate PR to allow a custom scorer object would be a good idea.
|
@OmarManzoor, would you like to have a look and merge this? |
OmarManzoor
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31889
If we really want to allow a custom scorer object, it probably should inherit from
_Scoreror_BaseScorerand those need to be public, but that can be a separate PR.