MNT remove PA_C from SGD and (re-) use eta0 #31932
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* no deprecation cycle as PA_C was not yet released (as of scikit-learn 1.7)
|
Question for reviewers: How can I add this PR to the whatsnew entry of #29097? The new towncrier is nice but I have no clue how to accomplish this (need it for other PRs too). @adrinjalali @OmarManzoor friendly ping as you reviewed #29097. |
|
@lorentzenchr Maybe specify something like But I think @adrinjalali might be able to provide a better suggestion in this regard |
|
@OmarManzoor Where should I use your suggestion? |
I was replying with respect the changelog entry question you mentioned |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Follow-up of #29097.
What does this implement/fix? Explain your changes.
This PR removes the newly introduces (not yet released)
PA_Cparameter of SGD and reuses the already existingeta0to specify the aggressiveness parameter for the passive-aggressive algorithm.Any other comments?
No deprecation cycle need if merged before 1.8 release.