-
-
Notifications
You must be signed in to change notification settings - Fork 26.2k
ENH: Display the number of output features #31937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I wonder if I can have feedback before I add/fix more tests. |
One feedback of @ogrisel IRL is to directly show the feature names using the same pattern than "Parameters". I personally agree with @jeremiedbb feedback: I would like something smaller. Also write now, we have to mention "output features" instead of simply "features" because of the ambiguity input/output when attached to the estimator. So the proposal to make the "feature" being blocks leaving on their own is nice I think because there is not ambiguity anymore. |
I'll work on this, thanks for the feedback. Just:
Should I add the feature names on this PR? I remember @glemaitre saying that they should be added on a separate PR. |
I want to dissociate it at first but since we are going to create a new block, it might be better to have directly the feature names as well. |
Reference Issues/PRs
Towards #26595
What does this implement/fix? Explain your changes.
This is part of "Display the (public) fitted attributes".
Any other comments?
Example
