CI add codecov to GitHub Action workflow #31941
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,6 +29,7 @@ if [[ "$COMMIT_MESSAGE" =~ \[float32\] ]]; then | |
| export SKLEARN_RUN_FLOAT32_TESTS=1 | ||
| fi | ||
|
|
||
| CHECKOUT_FOLDER=$PWD | ||
| mkdir -p $TEST_DIR | ||
| cp pyproject.toml $TEST_DIR | ||
| cd $TEST_DIR | ||
|
|
@@ -42,19 +43,19 @@ show_installed_libraries | |
| TEST_CMD="python -m pytest --showlocals --durations=20 --junitxml=$JUNITXML -o junit_family=legacy" | ||
|
|
||
| if [[ "$COVERAGE" == "true" ]]; then | ||
| # Note: --cov-report= is used to disable too long text output report in the | ||
| # CI logs. The coverage data is consolidated by codecov to get an online | ||
| # web report across all the platforms so there is no need for this text | ||
| # report that otherwise hides the test failures and forces long scrolls in | ||
| # the CI logs. | ||
| export COVERAGE_PROCESS_START="$CHECKOUT_FOLDER/.coveragerc" | ||
|
There was a problem hiding this comment. Similar comment as https://github.com/scikit-learn/scikit-learn/pull/31941/files#r2276870682. It feels slightly preferable to rely on the assumption that the current working directory is the scikit-learn repo root folder. |
||
|
|
||
| # Use sys.monitoring to make coverage faster for Python >= 3.12 | ||
| HAS_SYSMON=$(python -c 'import sys; print(sys.version_info >= (3, 12))') | ||
| if [[ "$HAS_SYSMON" == "True" ]]; then | ||
| export COVERAGE_CORE=sysmon | ||
| fi | ||
| TEST_CMD="$TEST_CMD --cov-config='$COVERAGE_PROCESS_START' --cov=sklearn --cov-report=" | ||
|
Comment on lines
-57
to
+58
There was a problem hiding this comment. This diff was necessary to fix the order of the cli arguments. For some reason, this was evaluated as |
||
| fi | ||
|
|
||
| if [[ "$PYTEST_XDIST_VERSION" != "none" ]]; then | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,5 +18,7 @@ dependencies: | |
| - pip | ||
| - ninja | ||
| - meson-python | ||
| - pytest-cov | ||
| - coverage | ||
| - pip | ||
| - ccache | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess one thing to think about for potential reviewers is whether we are OK with using an external GitHub action. Full disclosure: a few years ago the Codecov uploader was compromised see this.
The only secret being exposed would be the Codecov token. I am not sure how much harm can be done with this token (upload fake coverage reports to Codecov sure but something else?).
An alternative would be to use our Azure script
build_tools/azure/upload_coverage.shbuild_tools/azure/upload_codecov.shbut it would need to be adapted for GitHub, it uses Azure-specificBUILD_environment variables.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is the
build_tools/azure/upload_codecov.shfile.