Deprecate use of probability=True in SVC and NuSVC
#32050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Related to issue #31885
What does this implement/fix? Explain your changes.
this PR deprecates the use of probability=True in both SVC and NuSVC
Any other comments?
For now the default is set as
probability="deprecated"and later on it is set toprobability=False. This is as within the baselibsvm.fitfunction pyx code, probability is required to be a boolean integer. Perhaps in future we hard-code this as always being 0 (i.e., False), as we should not useprobability=True?FYI @ogrisel