-
-
Notifications
You must be signed in to change notification settings - Fork 26.2k
DOC: Improve terminology clarity in display classes(#30352) #32051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ Linting issuesThis PR is introducing linting issues. Here's a summary of the issues. Note that you can avoid having linting issues by enabling You can see the details of the linting issues under the
|
I see some test failures - are these related to my documentation changes or should I fix formatting issues? |
Thanks for your PR, you have some linting issues - #32051 (comment) describes how to fix them |
I see several test failures. Since my changes are documentation-only, |
Documentation is still checked for correct formatting and yes the CI failures are due to lint problems introduced in this PR.
Did you try this? You will need to install Please also do not change unrelated files. |
Hi @lucyleeow, Thank you for your feedback and for clarifying the lint and file change issues. I realized that my previous commits unintentionally included changes to unrelated files (e.g. benchmarks), most likely due to running ruff on the entire repository and getting caught in the pre-commit formatting loop. To keep things clean and focused, I’m going to reset my fork and open a fresh branch/PR containing only the intended documentation changes. I’ll update you here as soon as the new clean version is ready for review. Thank you for your guidance and patience! |
Hi @lucyleeow, Thank you for your feedback and guidance on this PR. I apologize for the complications that arose during the cleanup process, which resulted in the PR being accidentally closed due to a force push. I've successfully implemented your requested changes and created a new clean PR: #32057 |
This PR addresses issue #30352 by replacing ambiguous "chance level" terminology with clearer, more descriptive language across ROC and Precision-Recall display classes.
Changes:
Files changed:
sklearn/metrics/_plot/_roc_curve_display.py
sklearn/metrics/_plot/_precision_recall_display.py
Fixes #30352
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Any other comments?