Skip to content

Conversation

jeremiedbb
Copy link
Member

Follow-up of #31564

Tweaked the css a bit to make the whole cell of the parameter name clickable, with the help of @rouk1.

image

try it out in the doc build.

cc/ @DeaMariaLeon @glemaitre

Copy link

github-actions bot commented Sep 3, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: dc27fe5. Link to the linter CI: here

@DeaMariaLeon
Copy link
Contributor

Thanks for the ping! (and your PR :-)).

Sorry to be a pain, but I still can't see the user experience difference between the doc build with this PR, and the css in #31564 after Gaël's comment and my subsequent commit.

The whole parameter cell was clickable since then (for me). So, I would love to understand why it didn't work for you. Would it be because we are using different browsers? I tried with Safari and Chrome, (incognito and normal session). With vscode jupyter extension, and with plain Jupyter Notebook. It works locally and on the website (dev version) after the merge.

They all worked for me as a whole clickable parameter cell. Could you please tell me what you are using? Or if you have an idea of why this is happening?
Thanks in advance.

@jeremiedbb
Copy link
Member Author

jeremiedbb commented Sep 4, 2025

If I go back to the commit you mention, the link element doesn't take the whole space in the td. So the tooltip only appears when I hover over the light blue area (of the picture on the left). I get the same behavior on jupyter notebook (these pictures), firefox, chrome.

image image

Even if I remove the padding on the td element, it doesn't take the full height. Here you can see that the td is twice as high as the link.

image image

In the last commit of #31564, I added some padding to the link element as a workaround but it was not entirely satisfying because there was still a small non hoverable area at the top and bottom of the cell.

@DeaMariaLeon
Copy link
Contributor

Ohhhhhh... I see it! 🤓

Thank you very much for the screen-shots and (happily) your final explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants