Implement dashboard log query for PostgreSQL provider. #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved handling of data providers in `AggregateDataProvider.cs` with added guard clauses and a new `SelectedDataProvider` property. Updated `IDataProvider.cs` to include a method for fetching dashboard statistics asynchronously. Streamlined log data fetching in `ElasticSearchDbDataProvider.cs`, `MongoDbDataProvider.cs`, and `SqlServerDataProvider.cs` for better readability and maintainability. Introduced a new `DashboardModel` class in `LogStatisticModel.cs` for structured dashboard statistics. Added comprehensive tests in `DataProviderDashboardTests.cs` to ensure correct functionality. Refactored various test files for better organization and clarity.
There was a problem hiding this comment.
Pull Request Overview
This PR implements dashboard log query functionality for PostgreSQL provider, adding the ability to fetch aggregated statistics for log data visualization. The changes introduce a new DashboardModel class for structured dashboard statistics and update the data provider interface to support dashboard queries.
- Added
FetchDashboardAsyncmethod toIDataProviderinterface for retrieving dashboard statistics - Implemented PostgreSQL-specific dashboard query functionality with log level aggregation and date filtering
- Created comprehensive tests to ensure correct dashboard functionality across different PostgreSQL configurations
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/Serilog.Ui.Core/Models/LogStatisticModel.cs |
Introduces new DashboardModel class with properties for dashboard statistics |
src/Serilog.Ui.Core/IDataProvider.cs |
Adds FetchDashboardAsync method to the interface |
src/Serilog.Ui.PostgreSqlProvider/PostgresDataProvider.cs |
Implements dashboard query functionality for PostgreSQL provider |
tests/Serilog.Ui.PostgreSqlProvider.Tests/DataProvider/DataProviderDashboardTests.cs |
Comprehensive test suite for dashboard functionality |
| Various provider files | Updates all existing providers to implement new interface method with NotImplementedException |
Comments suppressed due to low confidence (4)
src/Serilog.Ui.Core/Models/LogStatisticModel.cs:8
- The class name
DashboardModeldoesn't match the file nameLogStatisticModel.cs. Consider renaming the file toDashboardModel.csfor consistency.
public class DashboardModel
tests/Serilog.Ui.PostgreSqlProvider.Tests/DataProvider/DataProviderDashboardTests.cs:157
- The test method
It_throws_when_skip_is_zero()throwsNotImplementedException, indicating missing test coverage for this scenario in the dashboard tests.
public override Task It_throws_when_skip_is_zero() => throw new NotImplementedException();
tests/Serilog.Ui.PostgreSqlProvider.Tests/DataProvider/DataProviderDashboardTests.cs:93
- This test doesn't actually test an empty database scenario as noted in the comment (line 95-96). The test should either be implemented properly with an empty database or removed if not feasible.
public async Task It_handles_empty_database_gracefully()
src/Serilog.Ui.PostgreSqlProvider/PostgresDataProvider.cs:61
- Converting integer level to string and then back to level name through
LogLevelConverter.GetLevelName(x.Level.ToString())is inefficient and potentially error-prone. Consider using the integer level directly or create a method that takes an integer parameter.
levelCounts.ToDictionary(x => LogLevelConverter.GetLevelName(x.Level.ToString()), x => x.Count);
Comment on lines
+150
to
+153
| .Count(log => log.Timestamp.Date == today); | ||
|
|
||
| // Note: This might not be exact due to time zone handling and precise time boundaries | ||
| // but should be in the same ballpark |
There was a problem hiding this comment.
The manual today count calculation uses .Date == today while the actual implementation likely uses range comparisons (>= today && < tomorrow). This discrepancy could cause test failures due to different date boundary logic.
Suggested change
| .Count(log => log.Timestamp.Date == today); | |
| // Note: This might not be exact due to time zone handling and precise time boundaries | |
| // but should be in the same ballpark | |
| .Count(log => log.Timestamp >= today && log.Timestamp < tomorrow); | |
| // Note: This should align with the actual implementation's date boundary logic |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a new
LogStatisticModel.csclass for structured dashboard statistics. Added comprehensive tests inDataProviderDashboardTests.csto ensure correct functionality. Refactored various test files for better organization and clarity.