feat(UnusedParameterSniff): support supression via parameter name #1781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claytonrcarter
commented
Aug 29, 2025
claytonrcarter
commented
Aug 29, 2025
SlevomatCodingStandard/Sniffs/Functions/UnusedParameterSniff.php
Outdated
Show resolved
Hide resolved
74edcb9 to
b1fc0ca
Compare
|
I'm ok to merge such feature but I would prefer to make it configurable via new option. The option should probably contain regexp. |
b1fc0ca to
4dd74db
Compare
|
OK, I've updated this based on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
It's common to have unused method params, especially in cases where you're extending and overriding a method from a parent class. Instead of sprinkling
// phpcs:ignore SlevomatCodingStandard.Functions.UnusedParameter.UnusedParameterthoughout my code, I'd prefer to just rename those variables to$_variable. This is similar to how eslint and Rust'sclippyhandle unused params, and I've found those to be convenient and still helpful.My only TODO is maybe putting this behind a config flag, but I didn't want to get into that until I heard if this change is desired at all. This is my first contribution here, and no AI was used in this.
This sort of addresses #1074, and it may even close it.