Handle <?> special symbol name from Scala 3 Semanticdb #635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafurpg
approved these changes
Aug 17, 2023
| @@ -12,6 +12,7 @@ | |||
| public final class SemanticdbSymbols { | |||
|
|
|||
| public static String NONE = ""; | |||
| public static String NONE_STUB = "<?>"; | |||
There was a problem hiding this comment.
Might be worth adding a comment explaining why this exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://sourcegraph.com/github.com/lampepfl/dotty/-/blob/compiler/src/dotty/tools/dotc/semanticdb/SemanticSymbolBuilder.scala?L59
I'm not sure if we can treat it as a local instead, given that it's explicitly coming from a failed local table lookup.
This is a stopgap solution to at least not completely crash over it.
Test plan
N/A - difficult to say if this behaviour is intentional on Scala 3 side